Skip to content

chore(deprecation): promote deprecated APIs from WARNING to ERROR#838

Open
devcrocod wants to merge 1 commit into
mainfrom
chore/deprecation-warning-to-error
Open

chore(deprecation): promote deprecated APIs from WARNING to ERROR#838
devcrocod wants to merge 1 commit into
mainfrom
chore/deprecation-warning-to-error

Conversation

@devcrocod

Copy link
Copy Markdown
Contributor

Raise @deprecated level to ERROR for the legacy ClientCapabilities constructor, ElicitRequest.requestedSchema, the ElicitRequestParams(...) factory, and the StdioServerTransport(inputStream, outputStream) constructor.

Migrate the internal and test call sites that consumed these now-ERROR APIs so everything still compiles:

  • elicitation DSL builds ElicitRequestFormParams directly
  • StreamableHttpServerTransport drops the in-band DNS-rebinding check (now handled by the DnsRebindingProtection plugin, as its handleRequest KDoc already documents)
  • integration test bases use the input/output stdio constructor
  • drop the deprecated-compat ElicitationTest cases

Raise @deprecated level to ERROR for the legacy ClientCapabilities
constructor, ElicitRequest.requestedSchema, the ElicitRequestParams(...)
factory, and the StdioServerTransport(inputStream, outputStream) constructor.

Migrate the internal and test call sites that consumed these now-ERROR
APIs so everything still compiles:
- elicitation DSL builds ElicitRequestFormParams directly
- StreamableHttpServerTransport drops the in-band DNS-rebinding check
  (now handled by the DnsRebindingProtection plugin, as its handleRequest
  KDoc already documents)
- integration test bases use the input/output stdio constructor
- drop the deprecated-compat ElicitationTest cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant